[24.1] Allow running and editing workflows for specific versions #18378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes the version prop to the routes for editing and running workflows and also to the `InvokeWorkflowPayload`, so that users can run specific versions of workflows. Fixes galaxyproject#18367
Show the name corresponding to the `WorkflowRun` form workflow's version.
ahmedhamidawan
force-pushed
the
workflow_run_edit_for_version
branch
from
f605470 to
2994a0f
Compare
mvdbeek
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
I think I would have preferred if we passed the workflow_id (and not the stored_workflow_id as we do currently) and the ?instance=true parameter instead. It's a bit unfortunate that I named our internal workflow checkpoints version when I added this. The version just corresponds to the number of workflows attached to a stored workflow, so if you import or copy a workflow that number is reset. This might be a little confusing.
ahmedhamidawan
added a commit
to ahmedhamidawan/galaxy
that referenced
this pull request
Jun 14, 2024
This is a bug caused in galaxyproject#18378 which made the `SaveChangesModal` useless because the version before the save was routed to. Now, we instead append the version to the route after the user confirms the save (or doesn't) in the modal.
ahmedhamidawan
added a commit
to ahmedhamidawan/galaxy
that referenced
this pull request
Jun 18, 2024
This is a bug caused in galaxyproject#18378 which made the `SaveChangesModal` useless because the version before the save was routed to. Now, we instead append the version to the route after the user confirms the save (or doesn't) in the modal.
ahmedhamidawan
added a commit
to ahmedhamidawan/galaxy
that referenced
this pull request
Jun 18, 2024
This is a bug caused in galaxyproject#18378 which made the `SaveChangesModal` useless because the version before the save was routed to. Now, we instead append the version to the route after the user confirms the save (or doesn't) in the modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the
versionprop to the routes for editing and running workflows and also to theInvokeWorkflowPayload, so that users can run specific versions of workflows.Fixes #18367
workflow_run_edit_for_version.mp4
How to test the changes?
(Select all options that apply)
License