Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix check for anonymous #18364

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jun 10, 2024

Fixes MultipleResultsFound error

https://sentry.galaxyproject.org/organizations/galaxy/issues/154954/?project=3&query=is%3Aunresolved&referrer=issue-stream&sort=freq&statsPeriod=24h&stream_index=1

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added this to the 24.1 milestone Jun 10, 2024
@jdavcs jdavcs requested a review from jmchilton June 10, 2024 22:49
@jdavcs jdavcs merged commit cea7eb0 into galaxyproject:release_24.1 Jun 11, 2024
50 of 51 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jun 11, 2024

That's a good catch, but it's not going to fix https://sentry.galaxyproject.org/organizations/galaxy/issues/154954/?project=3&query=is%3Aunresolved&referrer=issue-stream&sort=freq&statsPeriod=24h&stream_index=1, which is due to a logged in user who does not have a username running a job. So casting the presence of the username field to bool is just not correct if we don't provide a migration to assign usernames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants