[24.0] Fix anonymous user job retrieval logic

[davelopez]

Follow up to #18333

For anonymous users, if a history_id is provided, do not override it with the current session history; instead, rely on the history accessibility.

Hopefully addresses #18333 (comment)

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

I'd suggest filtering on the session id instead, that feel more direct ? Then you can change line 226-227 to

 if history_id is None and invocation_id is None and implicit_collection_jobs_id is None:
    # If we're not filtering on history, invocation or collection we filter the jobs owned by the current user
    if trans.user:
        stmt = stmt.where(Job.user_id == trans.user.id)
    elif trans.galaxy_session:
        stmt = stmt.where(Job.session_id == trans.galaxy_session.id)
    else:
        return None

(or instead of None the @nsoranzo variant to require a session ... I think we have an API decorator or depend method to annotate this on the API endpoint.)

[mvdbeek]

Thank you!

[nsoranzo]

Thanks, nice improvement! Going back to my original point, maybe raise an exception here?
It looks to me that an API client should either pass one of the 3 IDs or have at least an active session.

[davelopez]

Alright, I can do that, no-op seems fine, but I guess an error message will be more informative for API users in case they miss the parameter accidentally.

[nsoranzo]

Thanks!