Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Fix tool_shed package unit tests #18327

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 5, 2024

I've missed this one with all the other failing tests ...

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the title Fix tool_shed package unit tests [23.2] Fix tool_shed package unit tests Jun 5, 2024
@github-actions github-actions bot added this to the 23.2 milestone Jun 5, 2024
@mvdbeek mvdbeek requested a review from a team June 5, 2024 10:17
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more type annotation to prevent these :)

@mvdbeek
Copy link
Member Author

mvdbeek commented Jun 5, 2024

Agree, but that's tough for pytest fixtures, unless you annotate them in each function that uses them ...

@mvdbeek mvdbeek merged commit 02c1ec8 into galaxyproject:release_23.2 Jun 5, 2024
38 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants