Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix pinia in manually mounted components #18315

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Jun 4, 2024

Follow-up to #18299

It took me a while to figure it out, but the History Watcher stopped working whenever we were mounting a component this way. Turns out it was the store being wiped out 😅

Should fix the Selenium tests related to the tour generator currently broken:

FAILED lib/galaxy_test/selenium/test_tool_describing_tours.py::TestToolDescribingTours::test_generate_tour_with_data - selenium.common.exceptions.TimeoutException: Message: Failed waiting on history item 2 to become visible, visible datasets include [#dataset-dbc82ad822aa4805]. Timeout waiting on CSS selector [.history-index .content-item[data-hid="2"]] to become visible.

FAILED lib/galaxy_test/selenium/test_tool_describing_tours.py::TestToolDescribingTours::test_generate_tour_no_data - selenium.common.exceptions.TimeoutException: Message: Failed waiting on history item 1 to become visible, visible datasets include []. Timeout waiting on CSS selector [.history-index .content-item[data-hid="1"]] to become visible.

It also fixes a type error when ending the tour:

t.end is not a function
TypeError: t.end is not a function
    at HTMLButtonElement.<anonymous> (<anonymous>:340:1788)
    at HTMLButtonElement.dispatch (webpack://@galaxyproject/galaxy-client/./src/libs/jquery/jquery.js?:4737:27)
    at $event.dispatch (webpack://@galaxyproject/galaxy-client/./src/libs/jquery/jquery.event.drag.js?./node_modules/imports-loader/dist/cjs.js?imports=default%7CjqueryVendor%7CjQuery:386:19)
    at $event.dispatch (webpack://@galaxyproject/galaxy-client/./src/libs/jquery/jquery.event.drag.js?:381:19)
    at elemData.handle (webpack://@galaxyproject/galaxy-client/./src/libs/jquery/jquery.js?:4549:28)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

davelopez added 2 commits June 4, 2024 14:32
Otherwise the store will be wiped out whenever we mount a component manually.
@mvdbeek mvdbeek merged commit c681c0c into galaxyproject:release_24.1 Jun 4, 2024
50 of 51 checks passed
@davelopez davelopez deleted the 24.1_fix_pinia_in_manually_mounted_components branch June 4, 2024 13:59
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants