[24.1] Update parcel-built visualizations to use parcel v2 #18311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like only openlayers still failing to build: https://github.com/galaxyproject/galaxy/actions/runs/9369100590/job/25792755747?pr=18311#step:6:582 |
|
@mvdbeek Yep, was holding off to see if those first tweaks addressed the other issues before spamming CI again :) |
2.12 due to compatibility issues with d3, which will be resolved in a new release of parcel (2.13, soon)
…n may be why babel wasn't autoresolving the polyfill
…ecify @babel/core
…WG meeting; fail fast in CI so we can catch and resolve these.
until now, though this sure would have ensured that.
…e should consolidate towards a replacement
mvdbeek
approved these changes
Jun 6, 2024
|
@mvdbeek Yeah, it's a good step forward. And now, if any viz fails to build in CI it'll fail and be very obvious. I was working on adding more tests for other built-in visualizations, but I can follow up on that in dev. |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just a migration from v1 to v2 of parcel and some misc cleanup of a couple things I noticed along the way (build artifacts, unused libs). This fixes #18259, which is due to the visualization failing to build on test due to missing dependencies. Parcel v1 requires deasync, which uses node-gyp to compile c++, roping build tools into the process. This is slow and obviously fails when a build toolchain is unavailable.
If you notice, we're using two versions 2.12.0 and 2.11.0. This is because there's an issue with parcel 2.12.0 and the inclusion of d3, which causes invalid output during bundling, so d3-based visualizations are using 2.11.0 until 2.13.0 is out, which contains a fix.
I tested many of these manually, and verified they all built, but I did not manually run each visualization yet.
This also adds a configuration option
GALAXY_PLUGIN_BUILD_FAIL_ON_ERRORthat, when set, will cause a client build to fail when a plugin build returns a nonzero exit code. I changed the github action to set this in the env, so we'll catch breaking plugins moving forward.Still a few remaining tasks here; scatterplot is being a pain but making progress.
License