Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix Invenio credentials handling #18255

Conversation

davelopez
Copy link
Contributor

This fixes a regression introduced in #17997 where the user is forced to introduce credentials for Invenio/Zenodo even when just browsing public records.

The credentials are now required only for write operations.

Before After
image Screenshot from 2024-05-29 16-40-28

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • Without setting up your token in the preferences or as an anonymous user
    • Go to Upload -> Choose remote files -> select an Invenio based file source
    • You should be able to see the records instead of the error message

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Only ask for token when is really required
@davelopez davelopez force-pushed the 24.0_fix_invenio_credentials_handling branch from f673b86 to 7cfba26 Compare May 29, 2024 14:51
@mvdbeek mvdbeek merged commit 942ddea into galaxyproject:release_24.0 May 31, 2024
44 of 49 checks passed
@davelopez davelopez deleted the 24.0_fix_invenio_credentials_handling branch May 31, 2024 08:19
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants