Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Only log error if deleting directory really failed #18236

Merged
merged 1 commit into from
May 31, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 28, 2024

If we can't look up the directory it's safe to assume it really is gone. Fixes None delete error [Errno 39] Directory not empty: 'outputs_populated'.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

If we can't look up the directory it's safe to assume it really is gone.
Fixes `None delete error [Errno 39] Directory not empty:
'outputs_populated'`.
@mvdbeek mvdbeek requested a review from a team May 31, 2024 08:03
@nsoranzo nsoranzo merged commit 761a8d9 into galaxyproject:release_24.0 May 31, 2024
50 checks passed
@nsoranzo nsoranzo deleted the none_delete_error branch May 31, 2024 09:42
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants