Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Fix element serialization for collections that aren't populated yet #18235

Merged
merged 1 commit into from
May 28, 2024
Merged

[24.0] Fix element serialization for collections that aren't populated yet #18235

merged 1 commit into from
May 28, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 28, 2024

Fixes
#17818 (comment):

AttributeError
'NoneType' object has no attribute 'dataset'

MInor followup to #17818

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Fix element serialization for collections that aren't populated yet
0359063 
Fixes
galaxyproject#17818 (comment):
```
AttributeError
'NoneType' object has no attribute 'dataset'
```
@mvdbeek mvdbeek requested a review from davelopez May 28, 2024 06:18
davelopez
davelopez approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and Sentry both!

@davelopez davelopez merged commit ce53c7c into galaxyproject:release_24.0 May 28, 2024
50 checks passed
@martenson martenson deleted the accessible_followup branch June 9, 2024 15:24
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/API kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdbeek @davelopez @jdavcs