Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Decrease log level for expected visualization errors #18229

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 27, 2024

Minor followup to #18211. If we've got a MessageException I don't think we need to log this as an error, since we're also showing a reasonable message to the user.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Minor followup to galaxyproject#18211.
If we've got a MessageException I don't think we need to log this as an
error, since we're also showing a reasonable message to the user.
@jmchilton jmchilton merged commit 82a54a5 into galaxyproject:release_24.0 May 27, 2024
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants