Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Check dataset state when attempting to acces dataset contents #18214

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 23, 2024

Fixes a bunch of issues that are regularly logged in sentry.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@galaxyproject-sentryintegration

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/galaxy/webapps/galaxy/services/datasets.py

Function Unhandled Issue
show AttributeError: 'NoneType' object has no attribute 'get_filters' /api/datas...
Event Count: 16
show ValueError: invalid literal for int() with base 10: '2.60999' /api/datasets...
Event Count: 8
show ValueError: invalid literal for int() with base 10: '19.0941' /api/datasets...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good thanks!
Probably best to merge this forward before #18129

@jmchilton
Copy link
Member

Amazing honestly! Thanks so much. I feel like this is going to fix a lot of odd little issues I experience when playing with non-tradiational datasets.

@mvdbeek mvdbeek merged commit ae9ea86 into galaxyproject:release_24.0 May 24, 2024
51 checks passed
@galaxyproject-sentryintegration

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly /api/datasets/{dataset_id} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants