[24.1] Tighten axt sniffer #18204
Merged
[24.1] Tighten axt sniffer #18204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. it would incorrectly sniff chain as axt since the comment line starts with "##matrix=axtChain"
mvdbeek
reviewed
May 23, 2024
nsoranzo
reviewed
May 23, 2024
|
@bernt-matthias thanks for the suggestion! I added the test in 9ed4eda |
Co-authored-by: Nicola Soranzo <[email protected]>
|
The failed integration test is relevant. |
properly ignore comments do not read the dataset unbounded, I think we have enough info from the headers and the first data line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. it would incorrectly sniff chain as axt since the comment line starts with "##matrix=axtChain"
How to test the changes?
(Select all options that apply)
License