-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.0] Add GenericItem
error handling
#18203
Merged
dannon
merged 3 commits into
galaxyproject:release_24.0
from
ahmedhamidawan:fix_content_item_on_error
May 23, 2024
Merged
[24.0] Add GenericItem
error handling
#18203
dannon
merged 3 commits into
galaxyproject:release_24.0
from
ahmedhamidawan:fix_content_item_on_error
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GenericItem` was missing a `onError` function. Now, it catches backend errors and displays a `Toast` message for any failed operation. Fixes galaxyproject#18176
I think the toast is out of context here, could this be rendered in line ? As a user I couldn't really tell what the problem is in the screenshot. And I think all the delete/update methods in the component also need some error handling ? |
mvdbeek
reviewed
May 23, 2024
mvdbeek
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ahmedhamidawan!
mvdbeek
reviewed
May 23, 2024
Co-authored-by: Marius van den Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenericItem
was missing aonError
function. Now, it catches backend errors and displays aToast
message for any failed operation. Fixes #18176How to test the changes?
(Select all options that apply)
License