[24.0] Fix submitted value in workflow run form if data is constrained by tag filter #18193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be string or array
This now matched the filter in formattedOptions, so that upon first rendering there's no discrepancy with currentValue.
mvdbeek
force-pushed
the
fix_tag_filter_workflow_run_form
branch
from
9a830db to
ab2086d
Compare
|
Deployed this on main and have confirmation this is working correctly. Let's merge this, since submitting wrong values (even if the tag filter is a rare case we should probably not have implemented) is kind of bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported by @abueg, where inputs in the workflow run form appear to be correctly filtered by the tag value, but upon submission the unfiltered default value is used. The included selenium test recapitulates this.
How to test the changes?
(Select all options that apply)
License