-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.0] Prevent anonymous and inactive users from running workflows #18192
Merged
nsoranzo
merged 3 commits into
galaxyproject:release_24.0
from
ahmedhamidawan:prevent_anon_users_run_workflow
May 23, 2024
Merged
[24.0] Prevent anonymous and inactive users from running workflows #18192
nsoranzo
merged 3 commits into
galaxyproject:release_24.0
from
ahmedhamidawan:prevent_anon_users_run_workflow
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
May 21, 2024
nsoranzo
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a small API test for this please?
This would need to be an integration test since we need an instance that is configured to require user activation. |
ahmedhamidawan
force-pushed
the
prevent_anon_users_run_workflow
branch
from
May 22, 2024 17:37
5edab06
to
d0e460c
Compare
ahmedhamidawan
changed the title
[24.0] Prevent inactive users from running workflows
[24.0] Prevent anonymous users from running workflows
May 22, 2024
nsoranzo
reviewed
May 22, 2024
mvdbeek
reviewed
May 23, 2024
nsoranzo
reviewed
May 23, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
ahmedhamidawan
changed the title
[24.0] Prevent anonymous users from running workflows
[24.0] Prevent anonymous and inactive users from running workflows
May 23, 2024
mvdbeek
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18147
How to test the changes?
(Select all options that apply)
License