Merge 24.0 into dev #18177
Merged
Merge 24.0 into dev #18177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_pja [24.0] Don't commit in ``DeleteIntermediatesAction``
…values_not_getting_added_to_history [24.0] Fix data default values not getting added to history
need to gate this behind a loading span, it'll just show the alert when and if it needs to on load.
…uccess_prop [24.0] Fix undefined `reading 'produces_entry_points'` TypeError
`.children` is a HTMLCollection object which doesn't have a forEach interface. I confirmed this renders a few old style pages successfully. Fixes galaxyproject#18144
…storagemanager [24.0] Fix config access in StorageManager
Co-authored-by: Dannon <[email protected]>
[24.0] Fix Legacy HTML page view
The config typically is already loaded once you hit the tool form, so this shouldn't cause a delay, and we already do the same effectively for the current user and current history id. Fixes galaxyproject#18139 ``` TypeError: e.config is null at $b (webpack://@galaxyproject/galaxy-client/./src/components/Tool/ToolForm.vue?5639:1:1709) at Vue.prototype._render (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:2540:28) at updateComponent (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:2980:27) at Watcher.prototype.get (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:4164:33) at Watcher.prototype.run (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:4240:30) ... (3 additional frame(s) were not displayed) ```
…endering_until_config_loaded [24.0] Delay tool form rendering until config is loaded
There are only two places in the code where we set the job state to error (https://github.com/galaxyproject/galaxy/blob/ad9271cf6a33cb2e22bd7bed72f901e5215309da/lib/galaxy/jobs/handler.py#L722, https://github.com/galaxyproject/galaxy/blob/ad9271cf6a33cb2e22bd7bed72f901e5215309da/lib/galaxy/jobs/handler.py#L733) and both log more specific log messages.
…uest_invalid_url [24.0] Raise ``RequestParameterInvalidException`` when url is invalid
…ror_message [24.0] Drop redundant error message
…o_restricted_access_message [24.0] Fix error message when accessing restricted Zenodo records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License