Harden User Object Store and File Source Creation #18172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
file_source_templates_2
branch
3 times, most recently
from
cc3e41b to
c2bdc82
Compare
Add URLs where I have them in the dropdown.
Again thanks to David!
Provide detailed error message before proceeding with creation.
jmchilton
force-pushed
the
file_source_templates_2
branch
from
c2bdc82 to
2a92bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest #18127 with an added layer of checking file sources and object store configurations before persisting them down to the level of instantiating actual plugins. This catches a wide class of errors right away and provides much nicer feedback to users (and admins writing these plugins) about them.
I have WIP on a deeper UI for this but playing with it as is... was a huge step forward for usability so I thought I would open a PR for this part in case it turns green and people want to play with this version instead.
How to test the changes?
(Select all options that apply)
License