Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Drop redundant error message #18156

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 15, 2024

There are only two places in the code where we set the job state to error
(

return JOB_ERROR, job_destination
,
return JOB_ERROR, job_destination
) and both log more specific log messages.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone May 15, 2024
@galaxyproject-sentryintegration

Sentry Issue: GALAXY-MAIN-K

@mvdbeek mvdbeek merged commit d638bf4 into galaxyproject:release_24.0 May 15, 2024
49 of 50 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the drop_redundant_error_message branch May 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants