Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revises handling of warnings in the workflow run form #18126

Merged
merged 15 commits into from
May 14, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented May 11, 2024

Fixes #18077.

This PR replaces the workflow run form warning messages, and redirects the user to the workflow editor instead. It also contains refactoring towards typescript and composition api.

If the user attempts to run a public workflow which contains changes and requires review, the following message is shown, and the workflow is imported before loading the workflow editor:
image

If the user already owns the workflow, the workflow editor is loaded directly upon clicking the link shown in the message:
image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler requested a review from mvdbeek May 13, 2024 06:05
@guerler guerler force-pushed the workflow_run_warnings branch from cae4927 to 1b9ff32 Compare May 13, 2024 06:11
@guerler guerler marked this pull request as ready for review May 13, 2024 10:53
@dannon dannon merged commit f6de20c into galaxyproject:dev May 14, 2024
58 checks passed
@guerler guerler deleted the workflow_run_warnings branch May 14, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplified workflow run form warnings are vague
2 participants