Fix AWS object store for us-east-2 #18100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
May 7, 2024
| @@ -581,7 +601,7 @@ def _create(self, obj, **kwargs): | |||
|
|
|||
| def _empty(self, obj, **kwargs): | |||
| if self._exists(obj, **kwargs): | |||
| return bool(self._size(obj, **kwargs) > 0) | |||
| return bool(self._size(obj, **kwargs) == 0) | |||
There was a problem hiding this comment.
I think all the other object stores have the same issue. And we could drop the unnecessary bool cast.
mvdbeek
approved these changes
May 7, 2024
I went to write my first object store and there is like 400 lines of code in each and about 20 are different between them all - everyone just copy and pasted and changed a little 😿. I will remove... a great majority of the duplication in a follow up PR that will include my |
|
Thank you @jmchilton, really appreciate that, and happy to help out with this if you want to break that task apart. |
jdavcs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boto uses an older style signature for signing requests to AWS (v2). This is no allowed for regions created after 2014 - such as us-east-2. The newer style signatures can be turned on for newer regions but it requires also specifying a host. So the work around I worked through is allowing a region to be specified and if a region is specified just use the newer signatures and specify a host automatically. I put this all in the code as comments and I used it to run through a test case for AWS storage.
When we launch with #15875 I am guessing we probably want to allow a boto3 object store to be used. It has much easier multiprocess uploading and I think doesn't require this guess and check for the host and region and has been updated since 2018 unlike this older stuff.
How to test the changes?
(Select all options that apply)
License