-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.0] Raise exception if collection elements missing during download #18094
[24.0] Raise exception if collection elements missing during download #18094
Conversation
8af8764
to
da87bd2
Compare
Co-authored-by: Marius van den Beek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to separate backend and frontend fix if you want, returning an exception here is already a better UX than the 500 users would get.
No, thanks, I'm working on it. I'll get it done today. |
da87bd2
to
f218a39
Compare
Thank you! |
Fixes #18075
To do:
Is this a good location for raising the exception? I assume if that method is called, the collection must be populated? Or should we let it break and catch the AttributeError instead in the api module?
How to test the changes?
(Select all options that apply)
License