Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Raise exception if collection elements missing during download #18094

Merged
merged 5 commits into from
May 12, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented May 3, 2024

Fixes #18075

To do:

  • Decide what type of exception to raise instead of generic Exception
  • Client fix: grey out the download button if the collection isn't populated yet

Is this a good location for raising the exception? I assume if that method is called, the collection must be populated? Or should we let it break and catch the AttributeError instead in the api module?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs force-pushed the 240_emptycolldownload branch from 8af8764 to da87bd2 Compare May 9, 2024 17:28
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to separate backend and frontend fix if you want, returning an exception here is already a better UX than the 500 users would get.

@jdavcs
Copy link
Member Author

jdavcs commented May 10, 2024

I'm happy to separate backend and frontend fix if you want, returning an exception here is already a better UX than the 500 users would get.

No, thanks, I'm working on it. I'll get it done today.

@jdavcs jdavcs force-pushed the 240_emptycolldownload branch from da87bd2 to f218a39 Compare May 10, 2024 20:09
@jdavcs jdavcs marked this pull request as ready for review May 10, 2024 20:09
@github-actions github-actions bot added this to the 24.1 milestone May 10, 2024
@mvdbeek mvdbeek merged commit 8ff7e2f into galaxyproject:release_24.0 May 12, 2024
52 of 53 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented May 12, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants