Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure history update_time is set when exporting #18086

Merged
merged 3 commits into from
May 2, 2024

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented May 2, 2024

Addresses #18068 (comment)

The default is now so we should always have a value in the Python model even if the column can be nullable.
561e6e9 opened a can of worms... so falling back to a simple fix. At this point, we can be sure the history update_time will never be None.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

The default is `now` so we should have always a value in the Python model even if the column can be nullable.
@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/backend labels May 2, 2024
@github-actions github-actions bot added this to the 24.1 milestone May 2, 2024
@davelopez davelopez requested review from nsoranzo and jdavcs May 2, 2024 16:02
@davelopez davelopez changed the title Fix update_time typing in models Ensure history update_time is set when exporting May 2, 2024
@jdavcs
Copy link
Member

jdavcs commented May 2, 2024

Thank you, @davelopez!

@jdavcs jdavcs merged commit fa2afe8 into galaxyproject:dev May 2, 2024
54 checks passed
@davelopez davelopez deleted the fix_update_time_typing branch May 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants