[24.0] Improve error message for Extract dataset tool
#18078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a reasonable error message to users, instead of the internal error https://sentry.galaxyproject.org/share/issue/a197159192b64b9db065a762ee5dbbfc/: ``` KeyError: 'Dataset collection has no element_identifier with key 2.' File "galaxy/tools/__init__.py", line 1972, in handle_single_execution rval = self.execute( File "galaxy/tools/__init__.py", line 2069, in execute return self.tool_action.execute( File "galaxy/tools/actions/model_operations.py", line 88, in execute self._produce_outputs( File "galaxy/tools/actions/model_operations.py", line 119, in _produce_outputs tool.produce_outputs( File "galaxy/tools/__init__.py", line 3351, in produce_outputs extracted_element = collection[incoming["which"]["identifier"]] File "galaxy/model/__init__.py", line 6434, in __getitem__ raise KeyError(error_message) ``` Also makes the `identifier` parameter explicitly required (it is now inferred to be optional because text parameters are by default optional if no validator raises an exception upon validating an empty string). That prevents ``` KeyError: 'Dataset collection has no element_identifier with key None.' File "galaxy/tools/__init__.py", line 1972, in handle_single_execution rval = self.execute( File "galaxy/tools/__init__.py", line 2069, in execute return self.tool_action.execute( File "galaxy/tools/actions/model_operations.py", line 88, in execute self._produce_outputs( File "galaxy/tools/actions/model_operations.py", line 119, in _produce_outputs tool.produce_outputs( File "galaxy/tools/__init__.py", line 3351, in produce_outputs extracted_element = collection[incoming["which"]["identifier"]] File "galaxy/model/__init__.py", line 6434, in __getitem__ raise KeyError(error_message) ```
mvdbeek
force-pushed
the
better_exception_extract_dataset
branch
from
c522b4b to
acec4f6
Compare
Fixes the occasional timeout error in jobs that follow the `test_abort_fetch_job` test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a reasonable error message to users, instead of the internal error https://sentry.galaxyproject.org/share/issue/a197159192b64b9db065a762ee5dbbfc/:
Also makes the
identifierparameter explicitly required (it is now inferred to be optional because text parameters are by default optional if no validator raises an exception upon validating an empty string).That prevents
How to test the changes?
(Select all options that apply)
License