Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for https://sentry.galaxyproject.org/organizations/galaxy/issues/… #17979

Closed

Conversation

bgruening
Copy link
Member

This hopefully fixes: https://sentry.galaxyproject.org/organizations/galaxy/issues/148718/?project=7

Looks like there was no unique before the change: https://github.com/galaxyproject/galaxy/blame/19a1f90a96cbf245949b1bbd6b9019482ffceade/lib/galaxy/tools/actions/upload_common.py

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bgruening bgruening requested a review from jdavcs April 12, 2024 19:10
@github-actions github-actions bot added this to the 24.1 milestone Apr 12, 2024
@jdavcs
Copy link
Member

jdavcs commented Apr 12, 2024

The right fix is here: 6815239 (I fixed it for dev, but not 23.2, sorry!)
(i.e., unique must be applied to the result)

@bgruening
Copy link
Member Author

I had this fix at first, but could not see the unique in the older versions. Do you want to backport your fix? Or should I?

@jdavcs
Copy link
Member

jdavcs commented Apr 12, 2024

I had this fix at first, but could not see the unique in the older versions. Do you want to backport your fix? Or should I?

Doing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants