Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Set from_tool_form: true when saving new workflow #17972

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 11, 2024

Fixes #17963 and #17970. Since #17406 we've been using POST to create the first version of the workflow, but we're of course sending values emitted by the tool form, so from_tool_form: true is necessary here.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek force-pushed the fix_new_workflow_save branch from 71a40e7 to 0ec987f Compare April 11, 2024 17:36
@mvdbeek mvdbeek marked this pull request as ready for review April 11, 2024 17:37
@github-actions github-actions bot added this to the 23.2 milestone Apr 11, 2024
@martenson martenson merged commit 346b85f into galaxyproject:release_23.2 Apr 11, 2024
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants