Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typed API client for reporting job errors. #17969

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

jmchilton
Copy link
Member

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Merge Error reporting unit tests #17968, set email_error_to in galaxy.yml to anything and set smtp_server to point at a file like this ''mock_emails_to_path:///Users/jxc755/workspace/galaxy/email.json'. Find a dataset error in a history, click the bug icon and send one. Check email.json for the email that would be sent in production.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes area/API area/client labels Apr 11, 2024
@jmchilton jmchilton mentioned this pull request Apr 11, 2024
4 tasks
@jmchilton jmchilton marked this pull request as ready for review April 11, 2024 17:57
@github-actions github-actions bot added this to the 24.1 milestone Apr 11, 2024
@martenson martenson merged commit 8568c9e into galaxyproject:dev Apr 11, 2024
32 checks passed
@martenson martenson deleted the axios_to_fetcher_job_errors branch April 12, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/client kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants