Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Fix missing implicit conversion for mapped over jobs #17952

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 9, 2024

Fixes #17940, and also adds support for uploading binary or compressed datasets within the test_data: section.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Apr 9, 2024
@mvdbeek mvdbeek changed the title [23.2] Fix implicit conversion mapped over [23.2] Fix missing implicit conversion for mapped over jobs Apr 9, 2024
mvdbeek added 2 commits April 9, 2024 19:44
This test fails because cut fails on the compressed input with
`cut: /private/var/folders/df/6xqpqpcd7h73b6jpx9t6cwhw0000gn/T/tmpu8gqd71c/tmpmae9egoz/tmpz8sonmgx/database/objects/6/9/8/dataset_69847aef-7b3f-4915-a8ae-394921dbe388.dat: Illegal byte sequence`
@mvdbeek mvdbeek force-pushed the fix_implicit_conversion_mapped_over branch from 19099a9 to ec6a8e7 Compare April 9, 2024 17:44
@martenson martenson modified the milestones: 23.2, 24.1 Apr 9, 2024
@mvdbeek mvdbeek merged commit 206fe02 into galaxyproject:release_23.2 Apr 10, 2024
42 of 46 checks passed
@martenson martenson deleted the fix_implicit_conversion_mapped_over branch April 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants