Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Form elements refactors #17921

Draft
wants to merge 36 commits into
base: dev
Choose a base branch
from

Conversation

itisAliRH
Copy link
Member

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

return null;
}

const regex = new RegExp("^(\\w+\\.?)*\\w+$", "g");

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings containing many repetitions of '0'.
@itisAliRH itisAliRH marked this pull request as ready for review April 9, 2024 11:50
@itisAliRH itisAliRH marked this pull request as draft April 9, 2024 11:50
@itisAliRH itisAliRH force-pushed the form-elements-refactors branch from fc28650 to f4884b5 Compare April 9, 2024 11:51
@itisAliRH itisAliRH force-pushed the form-elements-refactors branch from 115325b to e84658b Compare April 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant