[24.0] Fix saving user preferences crashes tab #17917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17862
The cause was a computed setter triggering an infinite loop.
The computeds getter was getting a bool value, while it's setter was toggling the value (not setting it)
In combination with a library component which was triggering the setter on getter changes, this caused an infinite loop when the bool value was set to true via code after component mount.
Due to this value being linked to UI components conditional rendering and the local storage, this rapid self-toggling quickly crashed the tab.
How to test the changes?
(Select all options that apply)
License