Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix saving user preferences crashes tab #17917

Conversation

ElectronicBlueberry
Copy link
Member

fixes #17862

The cause was a computed setter triggering an infinite loop.

The computeds getter was getting a bool value, while it's setter was toggling the value (not setting it)

In combination with a library component which was triggering the setter on getter changes, this caused an infinite loop when the bool value was set to true via code after component mount.

Due to this value being linked to UI components conditional rendering and the local storage, this rapid self-toggling quickly crashed the tab.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@martenson
Copy link
Member

The intermittency that I've seen was likely due to cleaning local/session storages while experimenting. But I did not make the step to activity bar. Thanks for solving this @ElectronicBlueberry!

@martenson martenson merged commit fecf279 into galaxyproject:release_24.0 Apr 5, 2024
28 of 29 checks passed
@martenson martenson modified the milestones: 24.0, 24.1 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants