Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Always discard session after __handle_waiting_jobs is done #17913

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 5, 2024

This should guarantee recovery of the job monitor thread and fix #17893. Alternative to #17908, which is close but I think this avoids guessing which exceptions we gotta do this for, and since it's part of the normal control flow we have some test coverage here.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek requested a review from jdavcs April 5, 2024 10:18
@github-actions github-actions bot added this to the 24.1 milestone Apr 5, 2024
@mvdbeek mvdbeek changed the base branch from dev to release_24.0 April 5, 2024 11:15
@mvdbeek mvdbeek closed this Apr 5, 2024
@mvdbeek mvdbeek reopened this Apr 5, 2024
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this!

@mvdbeek mvdbeek merged commit 249681d into galaxyproject:release_24.0 Apr 6, 2024
79 of 100 checks passed
Copy link

github-actions bot commented Apr 6, 2024

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants