Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Make wait_for_history_jobs look at jobs, not datasets #17892

Merged
merged 3 commits into from
Apr 3, 2024
Merged

[24.0] Make wait_for_history_jobs look at jobs, not datasets #17892

merged 3 commits into from
Apr 3, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 3, 2024

That fixes test_optional_workflow_output, which started failing after #17874, which removed the last static output of output_filter, and so there would never be any active datasets to wait on.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Make wait_for_history_jobs look at jobs, not datasets
8ab16a9 
That fixes test_optional_workflow_output, which started failing after
galaxyproject#17874, which removed the
last static output of `output_filter`, and so there would never be any
active datasets to wait on.
@mvdbeek mvdbeek changed the title [24.0] Make wait_for_history_jobs look at jobs, not datasets [24.0] Make wait_for_history_jobs look at jobs, not datasets Apr 3, 2024
@github-actions github-actions bot added this to the 24.1 milestone Apr 3, 2024
@nsoranzo
Copy link
Member

nsoranzo commented Apr 3, 2024

@mvdbeek Pushed 2 more commits to this PR as I was also looking on how to fix the failing API test, hope that's OK.

@mvdbeek mvdbeek merged commit ab2aa7d into galaxyproject:release_24.0 Apr 3, 2024
50 checks passed
@nsoranzo nsoranzo deleted the fix_assert_ok branch April 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/testing kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdbeek @nsoranzo