Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix release notes images and videos #17889

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Apr 3, 2024

  1. Fix links to videos
  2. Use higher quality images

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

correct links to videos
better images
@github-actions github-actions bot added this to the 24.1 milestone Apr 3, 2024
@martenson martenson modified the milestones: 24.1, 24.0 Apr 3, 2024
Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we consider hosting the images on hub or elsewhere due to the size.

@jdavcs jdavcs merged commit c0b81c4 into galaxyproject:dev Apr 3, 2024
6 checks passed
@jdavcs
Copy link
Member Author

jdavcs commented Apr 3, 2024

I think we consider hosting the images on hub or elsewhere due to the size.

We could. It's not much though - only 1.6M for 2023 release notes, 0.5M for 2024 so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants