Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin activity to activity bar #17877

Merged
merged 16 commits into from
Apr 9, 2024
Merged

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 2, 2024

Adds an admin interface activity item to the activity bar.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.1 milestone Apr 2, 2024
@guerler guerler force-pushed the admin_activity branch 3 times, most recently from 6dfa24a to 2196940 Compare April 6, 2024 14:41
@guerler guerler marked this pull request as ready for review April 7, 2024 08:49
@martenson
Copy link
Member

lgtm, two minor ideas:

  • Clicking on admin in masthead could open the activity bar directly, duplicating the activity bar admin button and providing consistency. Currently admin is shown the admin page together with tool panel which is not very useful.
  • The "admin home" button would imho be better suited for "admin docs" linking to https://galaxyproject.org/admin/ and we could drop the "list of links" page. Later we could implement a proper dashboard in its place.

@guerler
Copy link
Contributor Author

guerler commented Apr 9, 2024

@martenson thank you for looking into it. Clicking on the admin masthead tab now toggles the admin activity panel. Regarding linking the admin docs instead of admin home, I would prefer that we just go ahead and add a simple dashboard instead of linking to an external resource.

@martenson martenson merged commit ce7ef77 into galaxyproject:dev Apr 9, 2024
55 checks passed
@martenson
Copy link
Member

thanks @guerler !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants