[24.0] Backport #16094 Missing outputs should be recorded as test errors
#17873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from planemo the verify_tool function is called from [within an try-except block](https://github.com/galaxyproject/planemo/blob/1aa3eb05a97ad20c0be6f6560ab5cec090e76612/planemo/engine/galaxy.py#L109) which silently catches any exception. Thus any exception raised from within verify_tool will not be detected, i.e. the assertion needs to be moved into `_verify_outputs` (which also seems to make sense by name) in order to make verify_tool record the problem properly.
thereby we implicitly make the assumption that a test needs to produce an output also make message more specific
otherwise the tool test will just return a list out of bounds exception which is unclear to the user
Co-authored-by: Marius van den Beek <[email protected]>
then it might be clearer what's going on here
4 tasks
|
@bernt-matthias Would you like to use this one instead of #16094? That one has one extra commit. If so, we can rename this PR, merge it and close 16094 (I assume the extra commit would be added here?). Otherwise, we could just retarget 16094 and merge it into the release_24.0 branch, and close this one. Or are they different? (in which case we can merge both) |
|
Lets go with #16094 and retarget .. I got confused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #16094
How to test the changes?
(Select all options that apply)
License