Add pin_labels attribute for image_diff comparison method
#17866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, objects could correspond to objects listed in `pin_labels` even if the label was different. Now, objects listed in `pin_labels` are prevented from being the corresponding objects of objects with different labels. This is overly more consistent and intuitive.
mvdbeek
reviewed
Apr 3, 2024
lib/galaxy/tool_util/parser/util.py
Outdated
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| DEFAULT_METRIC = "mae" | |||
| DEFAULT_EPS = 0.01 | |||
| DEFAULT_PIN_LABELS = "" | |||
There was a problem hiding this comment.
An empty string as the default value seems odd, is there a problem with making that None ?
There was a problem hiding this comment.
Right. Fixed that in 8515eed.
mvdbeek
approved these changes
Apr 3, 2024
|
This PR was merged without a "kind/" label, please correct. |
kostrykin
pushed a commit
to kostrykin/galaxy
that referenced
this pull request
Apr 4, 2024
…f_iou/upstream Add `pin_labels` attribute for `image_diff` comparison method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17556 we had introduced the
image_diffcomparison method for output verification, which supports different metrics for quantification of the image differences.The
ioumetric is designated for verification of label maps (images where the values correspond to labels of image regions). Usually the particular label values are interchangeable and only required to be distinct in order to be able to distinguish the differently labeled image regions. This fact is taken into account by theioumetric, which performs a pairwise comparison of uniquely labeled image regions, where pairs of corresponding regions are determined by maximizing the IoU.However, there also often are cases where specific label values are not interchangeable. The most prominent example are segmentation masks, where the image background is canonically labeled by 0 or -1, but the label values of the individual objects still are interchangeable. To also take such use cases into account, this PR adds the
pin_labelsattribute:The
pin_labelsattribute can be used to specify one or more labels, which are not interchangeable. For image regions labeled with those label values, the correspondences are established not by maximization of the IoU, but according to the label value itself.How to test the changes?
(Select all options that apply)
License