Update labels in Markdown editor when workflow labels change.

[jmchilton]

Extends the work of @assuntad23 and myself in #16864 and #17264 to handle spaces and quotes in labels better and to include workflow output labels in addition to input and step labels.

How to test the changes?

(Select all options that apply)

• Instructions for manual testing are as follows:
  1. Create a workflow with a label on one of the steps
  2. Go to edit the Report, and create an item in the report that references a label
  3. Navigate back to workflow steps, and change the label.
  4. Go back to the report and see that the label is changed.

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Pretty awesome! thank you so much for the tests!

It works pretty well! The only thing I found while testing is that it still needs to handle spaces in the label:

[jmchilton]

@davelopez Thanks for the screencast - I can reproduce the problem but I wrote unit tests so this seems unfair. I think the GUI should what the tests say it should 😆. I'll work on this next week - thanks for the review so much.

[jmchilton]

Okay - the function fails if labels contain spaces at the end... which they invariably will briefly if using a keyboard to type them in and we update on each keystroke. The missing test is obvious so that is great - I'll try to fix it now.

[jmchilton]

Okay - I think I fixed the problem in the screenshot view! Thanks again for the detailed review @davelopez

[davelopez]

Thank you! it works nicely!

[assuntad23]

thanks @jmchilton & @davelopez