Fix permissions for temporary upload file for API uploads #17850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that workflow test upload jobs jobs fail when testing against my instance (which uses a real user setup). Problem is that the temporary upload file does not respect the
umask
(because files created using tempfile just do not do this).The quick fix implemented here is fixing this by changing the permissions. Note that uploads via the web interface are not affected because they go this way.
Ultimately: it might be better to store the files in the job working dir, but this task seems to be to large for me.
How to test the changes?
(Select all options that apply)
License