Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odd object store exception #17810

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jmchilton
Copy link
Member

Screenshot 2024-03-21 at 4 10 55 PM

Anyone willing to deploy this to test and let me check if it fixes the problem? Happy to backport it if there is evidence it works.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek marked this pull request as ready for review March 22, 2024 08:12
@mvdbeek mvdbeek marked this pull request as draft March 22, 2024 08:12
@github-actions github-actions bot added this to the 24.1 milestone Mar 22, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Mar 25, 2024

Looks good to me and makes sense, happy to merge it

@jmchilton jmchilton changed the title Fix odd exception I see on test? Fix odd object store exception Mar 25, 2024
@jmchilton jmchilton marked this pull request as ready for review March 25, 2024 15:53
@bgruening bgruening merged commit 53e0ac5 into galaxyproject:dev Mar 25, 2024
56 checks passed
@martenson martenson deleted the older_object_stores branch April 22, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants