Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Return published histories first in display_by_username_and_slug #17808

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 21, 2024

slugs are not necessarily unique, but they are for published items. by returning the published histories first we return the intended history first, while making it possible for owners to retrieve their now unpublished histories by the old slug.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

slugs are not necessarily unique, but they are for published items.  by
returning the published histories first we return the intended history
first, while making it possible for owners to retrieve their now
unpublished histories by the old slug.
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martenson martenson modified the milestones: 24.1, 24.0 Mar 21, 2024
@martenson martenson merged commit e1b4d3f into galaxyproject:release_24.0 Mar 21, 2024
47 of 49 checks passed
@martenson martenson deleted the order_histories_by_importable_in_display_by_username_and_slug branch March 21, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants