-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset information refactors #17804
Dataset information refactors #17804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend rebasing with the latest dev branch, as recent type fixes might also affect it.
client/src/components/DatasetInformation/DatasetAttributes.test.ts
Outdated
Show resolved
Hide resolved
client/src/components/DatasetInformation/DatasetAttributes.test.ts
Outdated
Show resolved
Hide resolved
client/src/components/DatasetInformation/DatasetInformation.vue
Outdated
Show resolved
Hide resolved
75d73dd
to
ce2559b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @itisAliRH!
…ilsProvider` and `JobProblemProvider
Co-authored-by: David López <[email protected]>
…etHash` type from API
…, `DatasetSources` and `DatasetSourceTransform` components
…type from `DatasetInformation/services` to `api/jobs`
f7e17b6
to
9c9bf57
Compare
This PR was merged without a "kind/" label, please correct. |
This PR refactors the dataset information components to use CompositionAPI and typescript, imports icons and bootstrap components, removes
DatasetAttributesProvider
andJobProblemProvider
providers, and more logic improvements.One of the unit tests for
DatasetError
("does not hide form fields and button on error"
) was dropped because it required more complexity to pass. There are two problems:mockFetcher
can’t throw an error on error statuses and all errors need to be handled in service filesI could not find elsewhere that we are checking API errors in unit tests (it should be a way to do it)
Moreover, the
"/api/jobs/{job_id}/error"
API returns a status code of 200 when any error occurs, such as when the mail is not configured. Additionally, the error message returned by the API is an array instead of the common types we are using.How to test the changes?
(Select all options that apply)
License