Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset information refactors #17804

Merged
merged 39 commits into from
Apr 15, 2024

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Mar 21, 2024

This PR refactors the dataset information components to use CompositionAPI and typescript, imports icons and bootstrap components, removes DatasetAttributesProvider and JobProblemProvider providers, and more logic improvements.

One of the unit tests for DatasetError ("does not hide form fields and button on error") was dropped because it required more complexity to pass. There are two problems:

  1. mockFetcher can’t throw an error on error statuses and all errors need to be handled in service files
  2. The API does not return a generic error message (string) and can't be thrown as an error in service fils (throw new Error("Error Message"))
    I could not find elsewhere that we are checking API errors in unit tests (it should be a way to do it)

Moreover, the "/api/jobs/{job_id}/error" API returns a status code of 200 when any error occurs, such as when the mail is not configured. Additionally, the error message returned by the API is an array instead of the common types we are using.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH changed the title [WIP] Dataset information refactors Dataset information refactors Apr 4, 2024
@itisAliRH itisAliRH marked this pull request as ready for review April 4, 2024 13:37
@github-actions github-actions bot added this to the 24.1 milestone Apr 4, 2024
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend rebasing with the latest dev branch, as recent type fixes might also affect it.

@itisAliRH itisAliRH force-pushed the dataset-information-refactors branch from 75d73dd to ce2559b Compare April 9, 2024 09:58
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @itisAliRH!

@itisAliRH itisAliRH force-pushed the dataset-information-refactors branch from f7e17b6 to 9c9bf57 Compare April 15, 2024 12:05
@dannon dannon merged commit 7344b1d into galaxyproject:dev Apr 15, 2024
30 checks passed
@itisAliRH itisAliRH deleted the dataset-information-refactors branch April 15, 2024 16:07
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants