Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Prompt user to change default history permissions... #17782

Merged

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Mar 18, 2024

... if picking a private object store for that history.

First and easiest of a series of changes to improve handling of private storage. The other tasks are:

  • Do this same thing when changing the user's default permissions.
  • Do the inverse check when changing the history permissions.
  • Do the inverse check when changing the user's default history permissions.
  • Provide a much nicer explanation when these don't line up and give the user the ability to fix the problem from the error message.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • Good luck!

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

... if picking a private object store for that history.
@jmchilton jmchilton force-pushed the private_object_store_ui branch from 48e9697 to c1b7f65 Compare March 18, 2024 20:15
@martenson
Copy link
Member

Provide a much nicer explanation when these don't line up and give the user the ability to fix the problem from the error message.

💜

@jmchilton jmchilton marked this pull request as ready for review March 19, 2024 14:37
@github-actions github-actions bot added this to the 24.1 milestone Mar 19, 2024
@dannon dannon modified the milestones: 24.1, 24.0 Mar 19, 2024
@martenson martenson merged commit 4d33421 into galaxyproject:release_24.0 Mar 20, 2024
27 checks passed
@martenson
Copy link
Member

thank you @jmchilton !

@martenson martenson deleted the private_object_store_ui branch March 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants