Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Also set extension and metadata on copies of job outputs when finishing job #17777

Merged
merged 3 commits into from
Mar 19, 2024
Merged

[24.0] Also set extension and metadata on copies of job outputs when finishing job #17777

merged 3 commits into from
Mar 19, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 18, 2024 •
edited
Loading

Should fix #17771

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the title Also set extension and metadata on copies of job outputs when finishing job [24.0] Also set extension and metadata on copies of job outputs when finishing job Mar 18, 2024
@github-actions github-actions bot added area/jobs area/database Galaxy's database or data access layer area/tool-framework labels Mar 18, 2024
@mvdbeek mvdbeek force-pushed the fix_copy_of_hda_not_getting_metadata branch from fc71755 to 8f019e7 Compare March 18, 2024 16:07
@jmchilton
Copy link
Member

Reran the failing API tests - I was unsure if they were related.

@mvdbeek mvdbeek force-pushed the fix_copy_of_hda_not_getting_metadata branch from 8f019e7 to 8f23c62 Compare March 19, 2024 08:46
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 19, 2024

Yep, I was trying to copy the metadata for a JobToOutputDatasetAssociation instead of the HDA. It's high time we get sqlalchemy 2.0 and the typing improvements coming with it ...

@mvdbeek mvdbeek marked this pull request as ready for review March 19, 2024 09:46
@github-actions github-actions bot added this to the 24.1 milestone Mar 19, 2024
jdavcs
jdavcs approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@martenson martenson modified the milestones: 24.1, 24.0 Mar 19, 2024
@mvdbeek mvdbeek merged commit 020bfcd into galaxyproject:release_24.0 Mar 19, 2024
49 of 50 checks passed
@mvdbeek mvdbeek mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/jobs area/tool-framework kind/bug
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mvdbeek @jmchilton @jdavcs @martenson