[24.0] Add require_default_history route argument
#17755
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Mar 16, 2024
This is probably the simplest way to fix the anon user issue. If we don't have a history the size is 0, that's fairly simple. We might still want to do galaxyproject#17755 for those FastAPI endpoints that do actually require a default history.
This was referenced Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17703. The strategy introduced in #17657 started failing when applied to 24.0, since
/api/users/currentwas ported to FastAPI and so didn't result in the creation of a history. The effect of this was that if you didn't have a session cookie your first visit would fail to load the history panel.Going forward I think this is a nice way to provide resources conditionally per endpoint, instead of setting up everything in trans, whether it is needed or not for a given route.
How to test the changes?
(Select all options that apply)
License