Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in assert_has_image_n_labels #17754

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

kostrykin
Copy link
Contributor

Fix bug introduced in #17581: The argument labels was missing in assert_has_image_n_labels and is now added.

A test which covers this bug is added (fails before the fix).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@kostrykin
Copy link
Contributor Author

Maybe some explanation regarding the updated test:

Before, the argument labels was missing in lib/galaxy/tool_util/verify/asserts/image.py:254, and therefore exclude_labels was passed mistakenly for labels to the _get_image_labels function. Due to the structure of the test, the test passed. The test is now changed so that it fails if labels and exclude_labels are confused.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bgruening bgruening merged commit 5c1d045 into galaxyproject:dev Mar 16, 2024
49 of 54 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Mar 17, 2024
kostrykin pushed a commit to kostrykin/galaxy that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants