-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for galaxy packages against tpv #17747
base: dev
Are you sure you want to change the base?
Conversation
c392d4b
to
df70654
Compare
457ce1a
to
e52217e
Compare
e14924b
to
37ba3a5
Compare
I'm moving this back to draft because it didn't catch this issue: #17748 |
6b585f0
to
28bd715
Compare
run: | | ||
GALAXY_SKIP_NODE=1 GALAXY_SKIP_CLIENT_BUILD=1 make setup-venv | ||
# create local release | ||
echo "c" | UPSTREAM_REMOTE_URL="https://github.com/nuwang/galaxy.git" ./scripts/release.sh -l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporarily pointing to my upstream to simulate some additional missing files.
Co-authored-by: Nicola Soranzo <[email protected]>
63110e6
to
f0f2ff4
Compare
Can we turn this around and have TPV runs tests against multiple Galaxy versions ? That's the bioblend model and I think it works well ? Running this against each PR doesn't seem necessary, instead we can include the addition of new releases in the Galaxy release process ? |
f0f2ff4
to
0765c31
Compare
Are you saying that the github event trigger should change from PR to release? As long as we can detect releases with broken packages prior to release, that's fine I think. |
No, I'm suggesting to run the TPV tests in a cronjob from the TPV repo. We'll make sure you'll run against all relevant branches. |
For BioBlend, we use this: https://github.com/galaxyproject/bioblend/blob/main/.github/workflows/test.yaml#L2-L7 |
There tests are meant to catch Galaxy packaging errors, not TPV errors, so I think it defeats the purpose if Galaxy integration tests don't fail when packaging fails. In fact, TPV tests have broken numerous times (see linked issues above), when the breakage could have been detected and fixed at the point the breaking change was introduced into Galaxy. If the worry is that some TPV changes can break these tests, we can pin to a specific commit. |
I don't think it makes sense to run TPV tests to detect packaging issues, at least not on the Galaxy side as that's very indirect. If you want to contribute to more strict packaging tests that would of course be welcome. |
In the past, we've run into issues with TPV testing due to PyPI packaging, normally because a file was overlooked while bundling galaxy PyPI packages.
#16308
#14018
#14020
Most recently, this: #17748
TPV uses a fairly comprehensive gamut of Galaxy packages, so it seems like a good integration test target to make sure PyPI packaging is not overlooking required files.
How to test the changes?
(Select all options that apply)
License