Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Handle missing indexer for a dataset #17736

Conversation

ahmedhamidawan
Copy link
Member

In case a dataset does not have an indexer, raise an exception.
Fixes the bug mentioned in #17639 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

In case a dataset does not have an indexer, raise an exception.
Fixes the bug mentioned in galaxyproject#17639 (comment)
@ahmedhamidawan ahmedhamidawan changed the base branch from dev to release_23.1 March 15, 2024 22:29
Also, improve clarity a bit...
@ahmedhamidawan ahmedhamidawan force-pushed the dataset_handle_missing_indexer branch from 441f9a7 to d6914b7 Compare March 17, 2024 18:23
@mvdbeek mvdbeek merged commit 4b3bc55 into galaxyproject:release_23.1 Mar 18, 2024
31 of 37 checks passed
@martenson martenson modified the milestones: 24.1, 24.0 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants