[24.0] Improve published histories listing performance in UI #17717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially load only summary views, as the additional details are requested for each history after loading anyway.
mvdbeek
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
I think there is a followup issue in that https://usegalaxy.org/api/histories?limit=25&offset=0&search=&sort_by=update_time&sort_desc=true&show_own=false&show_published=true&show_shared=false&view=summary returns a bunch of things that are not part of HistorySummary (need to eliminate extra="allow" in the model), but in any case the summary view helps.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17665
Initially load only summary views, as the additional details are requested for each history after loading anyway.
Tested with
CHANGE_ORIGIN=true GALAXY_URL="https://usegalaxy.org/" make client-dev-serverLicense