Issue #17631: Make it possible to use custom invfile.lua if needed #17693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if needed mulled-build.py uses invfile.lua that comes pre-packaged with galaxy-tool-util. It would be nice if the user could specify a custom invfile.lua when (s)he needs to use a modified recipe for the image creation Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
mvdbeek
reviewed
Mar 13, 2024
| @@ -57,7 +57,7 @@ | |||
|
|
|||
| log = logging.getLogger(__name__) | |||
|
|
|||
| DIRNAME = os.path.dirname(__file__) | |||
| DIRNAME = os.environ.get("INVFILE_DIRNAME", os.path.dirname(__file__)) | |||
There was a problem hiding this comment.
This seems fine, but maybe we can be more direct here ?
Suggested change
| DIRNAME = os.environ.get("INVFILE_DIRNAME", os.path.dirname(__file__)) | |
| INVFILE = os.environ.get("INVFILE", os.path.join(os.path.dirname(__file__), "invfile.lua")) |
and then change line 269 to use that variable directly ?
It might also be nice to add this to the argparse parse in add_build_arguments and pass that on to mull_targets ?
There was a problem hiding this comment.
I've applied your suggestion!
But I'm afraid I don't follow you about add_build_arguments and mull_targets
There was a problem hiding this comment.
I've pushed a commit adding --involucro-lua-file, which defaults to INVFILE. That way users see it as a possible option when running mulled-build --help
galaxyproject#17693 (comment) Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
mvdbeek
approved these changes
Mar 13, 2024
|
Thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mulled-build.py uses invfile.lua that comes pre-packaged with galaxy-tool-util.
It would be nice if the user could specify a custom invfile.lua when (s)he needs to use a modified recipe for the image creation
How to test the changes?
Export
INVFILE_DIRNAMEenv var that points to a folder withinvfile.luain it and try to usemulled-buildtoo. It should use the custominvfile.luainstead of the one coming withgalaxy-tool-utilLicense