Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotation improvements #17601

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Type annotation improvements #17601

merged 5 commits into from
Mar 6, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Mar 5, 2024

(some from the CWL branch).

Also remove some unused methods/functions.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Mar 5, 2024
@nsoranzo nsoranzo force-pushed the type_annots branch 2 times, most recently from d9ca375 to 0315ab9 Compare March 6, 2024 00:10
@nsoranzo nsoranzo requested a review from a team March 6, 2024 01:54
davelopez
davelopez reviewed Mar 6, 2024
View reviewed changes
lib/galaxy/job_metrics/formatting.py Outdated Show resolved Hide resolved
lib/galaxy/tools/wrappers.py Outdated Show resolved Hide resolved
davelopez
davelopez approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvdbeek mvdbeek merged commit bc0d075 into galaxyproject:dev Mar 6, 2024
53 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

This PR was merged without a "kind/" label, please correct.

@davelopez davelopez added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Mar 6, 2024
@nsoranzo nsoranzo deleted the type_annots branch March 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/testing/integration area/testing area/tool-framework area/workflows kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nsoranzo @davelopez @mvdbeek