Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization and cleanup of job state related client code. #17593

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

jmchilton
Copy link
Member

Drop some backbone and unused code. Move other code from JS Vue to Typescript.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/workflows labels Mar 4, 2024
This was refactored and the refactored components needs the mixin only I think. xref galaxyproject@e289147
Use simpler types for greater reactivity, drop older style backbone model.
@jmchilton jmchilton force-pushed the invocation_cleanup branch from 5a5a857 to 11eaa3f Compare March 6, 2024 15:35
@jmchilton jmchilton force-pushed the invocation_cleanup branch from 11eaa3f to bf78004 Compare March 6, 2024 16:37
@jmchilton jmchilton marked this pull request as ready for review March 6, 2024 19:06
@github-actions github-actions bot added this to the 24.1 milestone Mar 6, 2024
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thank you!

@dannon dannon merged commit 17d015e into galaxyproject:dev Mar 12, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX area/workflows kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants